Kadomori Report

Analysis mode: Default rules (no LLM)
Signals used: default rules
Positioning: Surfaces candidate locations, necessity levels, and reasons that likely need human review. Does not assert mergeability or safety.

Evidence / Semantic Assist

• Deterministic evidence: information surfaced mechanically from git diff / default rules / team policy
• Semantic assist: supplementary perspectives added by the ACP LLM via semantic understanding (does not override facts or verdicts)
• Source breakdown of surfaced items: rule 49 / acp_agent 0 / merged 0

How to Read This Report

1. Executive Summary — grasp the overall picture from the verdict and reviewability score
2. Review Map — identify what to review in the order Human-required → Context-needed → Machine-verified
3. What the author should verify (when present) — actions to complete before creating the PR
4. What the reviewer should decide (when present) — points to surface during review

Executive Summary

• Reviewability: 55/100
• Verdict: NotReady (action needed before creating PR)
• Main reason: Relation to the goal needs explanation
• Slop risk: Medium
• PR granularity: TooBroad (too broad)
• Items requiring human judgment: 4
• Domain review: required (there are items requiring human domain judgment)
• Diff size: 35 files / +1174 / -201
• Top 3 Review Focus:
  1. Scope drift / out-of-scope change: .github/workflows/ci.yml — CI workflow: Config file changes are not part of the goal (and 2 more). verify whether this change should be included in this PR
  2. Slop risk Medium: representative finding R006 (Medium): crates/kadomori-cli/src/commands/init.rs:369: A catch-all error may be silently swallowed. Confirm with the author whether this fallback is intended — Verify the stub is not unintentional
  3. PR granularity TooBroad (too broad): Exceeds the 20-file limit (core review 23 / 20) — Input for deciding whether to split.

Score Breakdown

Review Burden Breakdown

• Human-required: 0 files
• Context-needed: 23 files
• Machine-verified: 12 files
• Items requiring human judgment: 4
• Author check items: 5
• Split suggested: yes
• Decision points surfaced before PR: 4 items
• omitted from handoff reviewer judgment: 15 items (reviewer judgment 4 / context check 9 / granularity / split 2) / source breakdown: rule-sourced 15
• omitted from explain review focus: 13 items (reviewer judgment 3 / context check 9 / granularity / split 1) / source breakdown: rule-sourced 13

Policy Coverage

• from default rule: 32 items
• from team policy: 0 items
• from policy seed: 0 items
• from ACP: 0 items

Git Summary

• Base: main
• Head: cursor/resolve-onboarding-friction-dfcd
• Changed files: 35
• Lines: +1174 / -201
• Diff mode: commit-to-commit
• Base SHA: c11827512b841e48f493de394c1543f76e1ad8a1
• Head SHA: 29ae2579831acdee29bbc2b734af55a6192d3d58

Warnings

None

Detailed Evidence

Slop Candidates

Risk: Medium

Representative detection reasons:

• R006 (Medium) crates/kadomori-cli/src/commands/init.rs:369: A catch-all error may be silently swallowed. Confirm with the author whether this fallback is intended — stub implementation: Verify the stub is not unintentional

Scope Drift

Goal: Resolve initial onboarding friction

• CI workflow: Config file changes are not part of the goal: 2 files (representative: .github/workflows/ci.yml)
• CHANGELOG.md: Release notes / changelog changes need explanation of their relation to the goal

PR Granularity

• Status: TooBroad (too broad)
• Reasons:
  • Exceeds the 20-file limit (core review 23 / 20)
  • Exceeds the 800-line limit (core review 1273 / 800, raw total 1375)
• Detected topics:
  • CI workflow / permissions: CI workflow changes: verify token permissions, secrets / OIDC, and deploy paths
  • CLI UX / commands: verify the intent of changes to CLI arguments, stdout / stderr, and dry-run flow
  • Markdown / handoff rendering: Markdown / handoff output changes: verify snapshots and actual output

Suggested PR Split

infra / CI

Infra / CI changes can be reviewed independently

• .github/workflows/ci.yml
• .github/workflows/release.yml

Changes in crates/kadomori-core

Files under directory crates/kadomori-core can be split together

• crates/kadomori-core/src/config/loader.rs
• crates/kadomori-core/src/config/mod.rs
• crates/kadomori-core/src/config/seed/mod.rs

rule-based analysis / pipeline

verdict / score / report impacts of analysis logic and pipeline changes can be reviewed together

• crates/kadomori-core/src/analysis/scope_drift.rs
• crates/kadomori-core/src/analysis/split_plan.rs

Markdown / handoff rendering

Markdown / handoff output changes can be reviewed together with snapshots and actual output

• crates/kadomori-core/src/render/pr_body.rs
• crates/kadomori-core/src/render/responsibility_contract.rs

CLI UX / commands

CLI argument / interactive UX changes can be reviewed together as the user flow Release notes accompany the main change. Check that their content matches the change.

• crates/kadomori-cli/src/commands/doctor.rs
• crates/kadomori-cli/src/commands/init.rs
• crates/kadomori-cli/src/commands/mod.rs
• CHANGELOG.md

Changes in scripts/fixtures

Files under directory scripts/fixtures can be split together

• scripts/fixtures/fake-gh.sh

tests

Test-only changes can be verified independently

• crates/kadomori-cli/tests/cli_integration.rs

documentation

Documentation changes can be split from the main code

• README.en.md
• README.md
• docs/distribution-archive-readme.md
• docs/distribution-repository-readme.md
• docs/kadomori-config-authoring.md
• docs/release-distribution.md
• docs/test-user-onboarding/README.en.md
• docs/test-user-onboarding/README.md
• docs/test-user-onboarding/release-readiness.md
• docs/test-user-onboarding/user-guide.md

supporting diff / snapshots

Review snapshot updates after the main diff, together with the corresponding test results and expected-value diffs

• crates/kadomori-cli/tests/snapshots/cli_integration__dogfood_pr38_rendering_detailed_evidence.snap
• crates/kadomori-cli/tests/snapshots/cli_integration__history_summary_markdown.snap
• crates/kadomori-cli/tests/snapshots/cli_integration__pr_body_no_llm_custom_output_summary.snap
• crates/kadomori-cli/tests/snapshots/cli_integration__pr_body_no_llm_default_summary.snap
• crates/kadomori-cli/tests/snapshots/cli_integration__pr_body_no_save_stdout_summary.snap
• crates/kadomori-core/src/render/snapshots/kadomori_core__render__pr_body__tests__pr_body_md.snap
• crates/kadomori-core/src/render/snapshots/kadomori_core__render__pr_body__tests__pr_body_md_en.snap

Changes in scripts

Files under directory scripts can be split together

• scripts/install.sh
• scripts/publish-release.sh
• scripts/test-release-distribution.sh

Review Map

Human-required

None

Context-needed

• CI workflow context: verify token permissions, fork PRs, secrets / OIDC, and release / deploy paths: 2 files (representative: .github/workflows/ci.yml) — Author action: Verify alignment with the PR goal and the behavior or output diff of representative cases, then write your findings in the PR body.
• CLI command change: verify arguments, output, exit codes, and backward compatibility: 3 files (representative: crates/kadomori-cli/src/commands/doctor.rs) — Author action: Verify alignment with the PR goal and the behavior or output diff of representative cases, then write your findings in the PR body.

  • crates/kadomori-cli/src/commands/doctor.rs
  • crates/kadomori-cli/src/commands/init.rs
  • crates/kadomori-cli/src/commands/mod.rs
• crates/kadomori-cli/tests/cli_integration.rs: CLI test: verify output regression, exit codes, and non-interactive flow — Author action: Verify alignment with the PR goal and the behavior or output diff of representative cases, then write your findings in the PR body.
• Context confirmation recommended: verify repository-specific intent: 4 files (representative: scripts/fixtures/fake-gh.sh) — Author action: Verify alignment with the PR goal and the behavior or output diff of representative cases, then write your findings in the PR body.

  • scripts/fixtures/fake-gh.sh
  • scripts/install.sh
  • scripts/publish-release.sh
  • scripts/test-release-distribution.sh
• Execution steps / hook / config snippet: verify official spec, local execution, and fail-open / blocking intent: 5 files (representative: README.en.md) — Author action: Verify alignment with the PR goal and the behavior or output diff of representative cases, then write your findings in the PR body.

  • README.en.md
  • README.md
  • docs/distribution-archive-readme.md
  • docs/distribution-repository-readme.md
  • docs/test-user-onboarding/README.md
• config value change: verify scope of impact, default values, and environment differences: [Config]: 3 files (representative: crates/kadomori-core/src/config/loader.rs) — Author action: Verify alignment with the PR goal and the behavior or output diff of representative cases, then write your findings in the PR body.

  • crates/kadomori-core/src/config/loader.rs
  • crates/kadomori-core/src/config/mod.rs
  • crates/kadomori-core/src/config/seed/mod.rs
• pipeline decision impact: verify the representative output of verdict / score / review map: 2 files (representative: crates/kadomori-core/src/analysis/scope_drift.rs) — Author action: Verify alignment with the PR goal and the behavior or output diff of representative cases, then write your findings in the PR body.
• CHANGELOG.md: release notes / changelog context: verify that the implementation diff, compatibility notes, and user-facing description match — Author action: Verify alignment with the PR goal and the behavior or output diff of representative cases, then write your findings in the PR body.
• rendering output impact: verify the readability of handoff / report.md / snapshot: 2 files (representative: crates/kadomori-core/src/render/pr_body.rs) — Author action: Verify alignment with the PR goal and the behavior or output diff of representative cases, then write your findings in the PR body.

Machine-verified

Note: Machine-verified does not mean "no review needed"; it means changes (tests, generated code, snapshots, etc.) that are easy to verify mechanically.

• Documentation-only change: verify accuracy of descriptions (no behavioral impact): 5 files (representative: docs/kadomori-config-authoring.md)
  • docs/kadomori-config-authoring.md
  • docs/release-distribution.md
  • docs/test-user-onboarding/README.en.md
  • docs/test-user-onboarding/release-readiness.md
  • docs/test-user-onboarding/user-guide.md
• snapshot diffs are easy to verify mechanically with golden tests: 7 files (representative: crates/kadomori-core/src/render/snapshots/kadomori_core__render__pr_body__tests__pr_body_md.snap)
  • crates/kadomori-cli/tests/snapshots/cli_integration__dogfood_pr38_rendering_detailed_evidence.snap
  • crates/kadomori-cli/tests/snapshots/cli_integration__history_summary_markdown.snap
  • crates/kadomori-cli/tests/snapshots/cli_integration__pr_body_no_llm_custom_output_summary.snap
  • crates/kadomori-cli/tests/snapshots/cli_integration__pr_body_no_llm_default_summary.snap
  • crates/kadomori-cli/tests/snapshots/cli_integration__pr_body_no_save_stdout_summary.snap
  • crates/kadomori-core/src/render/snapshots/kadomori_core__render__pr_body__tests__pr_body_md.snap
  • crates/kadomori-core/src/render/snapshots/kadomori_core__render__pr_body__tests__pr_body_md_en.snap

Human-only Decision Points

• Out-of-scope changes detected (Author): Relative to goal "Resolve initial onboarding friction", out-of-scope candidates such as .github/workflows/ci.yml are included, so the author should explain why they belong in this PR
• Confirm the intent of Markdown / handoff output (Reviewer): Change to crates/kadomori-core/src/render/pr_body.rs, crates/kadomori-core/src/render/responsibility_contract.rs: rendering changes affect the material reviewers rely on, so verify the golden snapshot and the actual readability
• Confirm the output impact of report decision logic (Reviewer): Change to crates/kadomori-core/src/analysis/scope_drift.rs, crates/kadomori-core/src/analysis/split_plan.rs: pipeline / analysis changes propagate to verdict, score, review map, and handoff output, so verify the diff on representative cases
• Confirm CLI interactive / non-interactive UX (Author): Change to crates/kadomori-cli/src/commands/mod.rs, crates/kadomori-cli/tests/cli_integration.rs: for CLI UX changes, verify the behavior for TTY prompts, non-TTY / pipe / CI, when --goal is specified, and when --non-interactive is specified

Responsibility Map

What Both Author and Reviewer Should Verify

• Confirm the intent of Markdown / handoff output (see Human-only Decision Points for the rationale): crates/kadomori-core/src/render/pr_body.rs, crates/kadomori-core/src/render/responsibility_contract.rs
• Confirm the output impact of report decision logic (see Human-only Decision Points for the rationale): crates/kadomori-core/src/analysis/scope_drift.rs, crates/kadomori-core/src/analysis/split_plan.rs
• Confirm CLI interactive / non-interactive UX (see Human-only Decision Points for the rationale): crates/kadomori-cli/src/commands/mod.rs, crates/kadomori-cli/tests/cli_integration.rs

What the Author Should Verify

Author Checklist

• Confirmed that this PR has a single purpose
• Confirmed that tests were added or updated
• Verified the handoff / report.md snapshot and the actual output
• Verified the changes in verdict / score / review map on representative cases
• Verified the representative behavior for TTY execution, non-TTY / pipe / CI, --goal, and --non-interactive

Generated by

• rule-based: true
• llm_attempted: false
• llm_succeeded: false
• llm_outcome: NotAttempted
• analysis_mode: Default rules (no LLM)
• signals: default_rules

Generated by Kadomori 0.2.3