Kadomori Pre-PR Handoff

This document is not a finished PR description; it is a confirmation trail for the author to review responsibly before opening a PR and hand off to reviewers and approvers.

Analysis mode: Default rules (no LLM)
Signals used: default rules
Positioning: Surfaces candidate locations, necessity levels, and reasons that likely need human review. Does not assert mergeability or safety.

Verdict	NotReady (action needed before creating PR) / Reviewability 55/100
Main reason	Relation to the goal needs explanation
Slop risk	Medium
PR granularity	TooBroad
Domain review	Required (items needing human domain judgment)
Diff size	35 files / +1174 / -201
How to read evidence	Deterministic evidence is based on git diff / rule / policy; Semantic assist is ACP's semantic support (it does not override facts or verdicts)
Score breakdown	Diff size -20 / Scope Drift -12 / Slop -8 / Domain review -5

Goal

Resolve initial onboarding friction

What the author must responsibly confirm before the PR

Explain why the out-of-scope change candidates are included in this PR
Confirmed that this PR has a single purpose
Confirmed that tests were added or updated
Verified the handoff / report.md snapshot and the actual output
Verified the changes in verdict / score / review map on representative cases
2 more items (rule-sourced 2): see the detailed evidence (.kadomori/report.md / .kadomori/report.json)

Kadomori confirmation candidates to copy into the PR body

The following is a draft to copy into the PR description. Keep only the facts you confirmed; do not delete unconfirmed items, but mark them as "unconfirmed".

**Kadomori confirmation**

- Context-needed: for CI workflow context: verify token permissions, fork PRs, secrets / OIDC, and release / deploy paths (2 files, representative: `.github/workflows/ci.yml`), Verify alignment with the PR goal and the behavior or output diff of representative cases, then write your findings in the PR body.
- Context-needed: for CLI command change: verify arguments, output, exit codes, and backward compatibility (3 files, representative: `crates/kadomori-cli/src/commands/doctor.rs`), Verify alignment with the PR goal and the behavior or output diff of representative cases, then write your findings in the PR body.
- Context-needed: for CLI test: verify output regression, exit codes, and non-interactive flow (`crates/kadomori-cli/tests/cli_integration.rs`), Verify alignment with the PR goal and the behavior or output diff of representative cases, then write your findings in the PR body.
- Scope drift: for out-of-scope change candidates such as `.github/workflows/ci.yml`, leave in the PR body the relationship to the goal and the reason for including it in this PR.
- Machine-verified: for `crates/kadomori-cli/tests/snapshots/cli_integration__dogfood_pr38_rendering_detailed_evidence.snap` and 11 more file(s), leave in the PR body the mechanical confirmation basis such as tests / generation commands / snapshot updates.

**Supplementary notes for reviewers**

- As needed, leave unconfirmed items or points needing approver judgment here.

NotReady — Consider before opening the PR

Kadomori's verdict is NotReady. This does not forbid creating a PR; it is a signal that you should consider addressing the following points before opening one.

Main reason: Relation to the goal needs explanation

Candidate text for the PR body:

**Response to Kadomori NotReady verdict**

- Context-needed 23 file(s): confirm consistency with the PR goal.
  - [ ] Added background and intent to the PR body
- Out-of-scope change candidates: out-of-scope changes were detected.
  - [ ] Explained the relationship to the goal or split into a separate PR

Copy this candidate text into the PR description and check the items you addressed. Do not delete unaddressed items; keep them.

What reviewers should judge

Top 3 Review Focus (review focus cards):

Scope drift / out-of-scope change: .github/workflows/ci.yml — CI workflow: Config file changes are not part of the goal (and 2 more). verify whether this change should be included in this PR
- Deterministic evidence: confirmation candidate based on git diff / rule / team policy
- Semantic assist: none
Slop risk Medium: representative finding R006 (Medium): crates/kadomori-cli/src/commands/init.rs:369: A catch-all error may be silently swallowed. Confirm with the author whether this fallback is intended — Verify the stub is not unintentional
- Deterministic evidence: confirmation candidate based on git diff / rule / team policy
- Semantic assist: none
PR granularity TooBroad (too broad): Exceeds the 20-file limit (core review 23 / 20) — Input for deciding whether to split.
- Deterministic evidence: confirmation candidate based on git diff / rule / team policy
- Semantic assist: none

15 more items (reviewer judgment 4 / context check 9 / granularity / split 2, rule-sourced 15): see the detailed evidence (.kadomori/report.md / .kadomori/report.json)

Breakdown of omitted confirmation items:

Omitted from handoff reviewer judgment: 15（reviewer judgment 4 / context check 9 / granularity / split 2） / source breakdown: rule-sourced 15
Omitted from explain review focus: 13（reviewer judgment 3 / context check 9 / granularity / split 1） / source breakdown: rule-sourced 13

Links to detailed evidence

Detailed report: .kadomori/report.md
Machine-readable facts: .kadomori/report.json
Policy coverage / gap candidates: see .kadomori/report.md / .kadomori/report.json
Split analysis details: kadomori split-plan --goal "..."

Detailed evidence

Scope / Review Map detailed evidence

Scope

Included changes

crates/kadomori-cli/tests/snapshots/cli_integration__dogfood_pr38_rendering_detailed_evidence.snap
crates/kadomori-cli/tests/snapshots/cli_integration__history_summary_markdown.snap
crates/kadomori-cli/tests/snapshots/cli_integration__pr_body_no_llm_custom_output_summary.snap
crates/kadomori-cli/tests/snapshots/cli_integration__pr_body_no_llm_default_summary.snap
crates/kadomori-cli/tests/snapshots/cli_integration__pr_body_no_save_stdout_summary.snap
crates/kadomori-core/src/render/snapshots/kadomori_core__render__pr_body__tests__pr_body_md.snap
crates/kadomori-core/src/render/snapshots/kadomori_core__render__pr_body__tests__pr_body_md_en.snap
docs/kadomori-config-authoring.md
docs/release-distribution.md
docs/test-user-onboarding/README.en.md
docs/test-user-onboarding/release-readiness.md
docs/test-user-onboarding/user-guide.md
.github/workflows/ci.yml
.github/workflows/release.yml
CHANGELOG.md
README.en.md
README.md
crates/kadomori-cli/src/commands/doctor.rs
crates/kadomori-cli/src/commands/init.rs
crates/kadomori-cli/src/commands/mod.rs
crates/kadomori-cli/tests/cli_integration.rs
crates/kadomori-core/src/analysis/scope_drift.rs
crates/kadomori-core/src/analysis/split_plan.rs
crates/kadomori-core/src/config/loader.rs
crates/kadomori-core/src/config/mod.rs
crates/kadomori-core/src/config/seed/mod.rs
crates/kadomori-core/src/render/pr_body.rs
crates/kadomori-core/src/render/responsibility_contract.rs
docs/distribution-archive-readme.md
docs/distribution-repository-readme.md
docs/test-user-onboarding/README.md
scripts/fixtures/fake-gh.sh
scripts/install.sh
scripts/publish-release.sh
scripts/test-release-distribution.sh

Out-of-scope change candidates

CI workflow: Config file changes are not part of the goal: 2 files (representative: .github/workflows/ci.yml)
- .github/workflows/ci.yml
- .github/workflows/release.yml
CHANGELOG.md: Release notes / changelog changes need explanation of their relation to the goal

Review Map

Context-needed:

CI workflow context: verify token permissions, fork PRs, secrets / OIDC, and release / deploy paths: 2 files (representative: .github/workflows/ci.yml, 1 more file) — Author action: Verify alignment with the PR goal and the behavior or output diff of representative cases, then write your findings in the PR body.
CLI command change: verify arguments, output, exit codes, and backward compatibility: 3 files (representative: crates/kadomori-cli/src/commands/doctor.rs, 2 more files) — Author action: Verify alignment with the PR goal and the behavior or output diff of representative cases, then write your findings in the PR body.
CLI test: verify output regression, exit codes, and non-interactive flow: 1 file (representative: crates/kadomori-cli/tests/cli_integration.rs) — Author action: Verify alignment with the PR goal and the behavior or output diff of representative cases, then write your findings in the PR body.
Context confirmation recommended: verify repository-specific intent: 4 files (representative: scripts/fixtures/fake-gh.sh, 3 more files) — Author action: Verify alignment with the PR goal and the behavior or output diff of representative cases, then write your findings in the PR body.
Execution steps / hook / config snippet: verify official spec, local execution, and fail-open / blocking intent: 5 files (representative: README.en.md, 4 more files) — Author action: Verify alignment with the PR goal and the behavior or output diff of representative cases, then write your findings in the PR body.
config value change: verify scope of impact, default values, and environment differences: [Config]: 3 files (representative: crates/kadomori-core/src/config/loader.rs, 2 more files) — Author action: Verify alignment with the PR goal and the behavior or output diff of representative cases, then write your findings in the PR body.
pipeline decision impact: verify the representative output of verdict / score / review map: 2 files (representative: crates/kadomori-core/src/analysis/scope_drift.rs, 1 more file) — Author action: Verify alignment with the PR goal and the behavior or output diff of representative cases, then write your findings in the PR body.
release notes / changelog context: verify that the implementation diff, compatibility notes, and user-facing description match: 1 file (representative: CHANGELOG.md) — Author action: Verify alignment with the PR goal and the behavior or output diff of representative cases, then write your findings in the PR body.
rendering output impact: verify the readability of handoff / report.md / snapshot: 2 files (representative: crates/kadomori-core/src/render/pr_body.rs, 1 more file) — Author action: Verify alignment with the PR goal and the behavior or output diff of representative cases, then write your findings in the PR body.

Machine-verified:

Documentation-only change: verify accuracy of descriptions (no behavioral impact): 5 files (representative: docs/kadomori-config-authoring.md)
- docs/kadomori-config-authoring.md
- docs/release-distribution.md
- docs/test-user-onboarding/README.en.md
- docs/test-user-onboarding/release-readiness.md
- docs/test-user-onboarding/user-guide.md
snapshot diffs are easy to verify mechanically with golden tests: 7 files (representative: crates/kadomori-core/src/render/snapshots/kadomori_core__render__pr_body__tests__pr_body_md.snap)
- crates/kadomori-cli/tests/snapshots/cli_integration__dogfood_pr38_rendering_detailed_evidence.snap
- crates/kadomori-cli/tests/snapshots/cli_integration__history_summary_markdown.snap
- crates/kadomori-cli/tests/snapshots/cli_integration__pr_body_no_llm_custom_output_summary.snap
- crates/kadomori-cli/tests/snapshots/cli_integration__pr_body_no_llm_default_summary.snap
- crates/kadomori-cli/tests/snapshots/cli_integration__pr_body_no_save_stdout_summary.snap
- crates/kadomori-core/src/render/snapshots/kadomori_core__render__pr_body__tests__pr_body_md.snap
- crates/kadomori-core/src/render/snapshots/kadomori_core__render__pr_body__tests__pr_body_md_en.snap

Slop risk details

R006 (Medium): crates/kadomori-cli/src/commands/init.rs:369: A catch-all error may be silently swallowed. Confirm with the author whether this fallback is intended — stub implementation: Verify the stub is not unintentional

Notes for Reviewers

No notes

Generated by

rule-based: true
llm_attempted: false
llm_succeeded: false
llm_outcome: NotAttempted
analysis_mode: Default rules (no LLM)
signals: default_rules